fix: enable metal_reserved_ip_block to create VRF IP reservations
#233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
displague
reviewed
Oct 4, 2024
| required_if=[ | ||
| ['type', 'vrf', ['vrf_id', 'cidr', 'network']], | ||
| ['type', 'public_ipv4', ['metro']] | ||
| ['type', 'public_ipv4', ['quantity', 'metro']], | ||
| ['type', 'private_ipv4', ['quantity']], |
There was a problem hiding this comment.
Wouldn't we also need metro for private_ipv4? (not sure that this is a generally consumable request type, so perhaps it is moot)
There was a problem hiding this comment.
It's possible, but this PR isn't a broad fix for all possible parameter validation in the metal_reserved_ip_block module; it's focused narrowly on fixing some validation that made the module completely unusable for VRF IP reservations. Adding the quantity requirement here and for global blocks maintains the previous validation behavior for those types while allowing VRF blocks to implement the correct validation.
ctreatma
changed the title
metal_reserved_ip_block to create VRF IP reservations
|
This PR is included in version 0.11.0 🎉 |
1 similar comment
|
This PR is included in version 0.11.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple problems with the parameter definitions for the reserved IP block module:
cidrandnetworkparameters, needed for VRF IP reservations, were not defined in the module specquantityparameter, which is unsupported for VRF IP reservations, was required in order to create any IP reservationThis PR updates the reserved IP block module so that it can be used to create a VRF IP reservation. The docs are also updated to reference the
cidrandnetworkparameters.This was broken out of #232.